You introduced new macros IsHeapRelation and IsViewRelation, but I don't
want to introduce such API. Such things have been heavily contested and
I don't to have one more thing to worry about for this patch, so please
just put the relkind directly in the code.
On 2019-Jan-07, Nikolay Shaplov wrote:
> I also reworked some comments. BTW do you know what is this comments spoke
> about:
>
> * RelationGetFillFactor() and RelationGetTargetPageFreeSpace() can only
> * be applied to relations that use this format or a superset for
> * private options data.
>
> It is speaking about some old times when there can be some other type of
> options? 'cause I do not understand what it is speaking about.
> I've removed it, I hope I did not remove anything important.
As I understand it's talking about the varlenas being StdRdOptions and
not anything else. I think extensibility could cause some relkinds to
use different options.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services