Re: Misleading panic message in backend/access/transam/xlog.c

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Misleading panic message in backend/access/transam/xlog.c
Дата
Msg-id 20190110010140.GD2157@paquier.xyz
обсуждение исходный текст
Ответ на Re: Misleading panic message in backend/access/transam/xlog.c  (Andres Freund <andres@anarazel.de>)
Ответы Re: Misleading panic message in backend/access/transam/xlog.c  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
On Wed, Jan 09, 2019 at 08:10:43AM -0800, Andres Freund wrote:
> I'm quite unenthused about that. If anything, I'd remove detail and use
> the standard error message about not being able to write to a file, and
> include the full path.

Partially agreed.  Those messages have been left out of 56df07b
because they include some context about the offset and the length, and
I don't think that we simply want to remove that information.  What
about making the offset and the length part of an extra errdetail, and
switch the main error string to a more generic one?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Making WAL receiver startup rely on GUC context forprimary_conninfo and primary_slot_name
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Misleading panic message in backend/access/transam/xlog.c