Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Дата
Msg-id 20190104133305.GG2067@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Christoph Berg <christoph.berg@credativ.de>)
Список pgsql-hackers
On Fri, Jan 04, 2019 at 11:41:15AM +0100, Peter Eisentraut wrote:
> Note that pgxs supports PG_CPPFLAGS for adding custom pieces to CPPFLAGS
> in a safe way.  Maybe we should add an equivalent for CFLAGS?  It's just
> that it hasn't been needed so far.

+1.  Wouldn't it make sense to also have PG_LDFLAGS?  In some stuff I
maintain, I have been abusing of PG_CPPFLAGS to pass some flags, which
is not really right.  We also have contrib/passwordcheck/Makefile
abuse of it to set -DUSE_CRACKLIB..
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Greg Stark
Дата:
Сообщение: Re: Custom text type for title text
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: Allow auto_explain to log to NOTICE