Re: reorderbuffer: memory overconsumption with medium-size subxacts

On 2018-Dec-16, Andres Freund wrote:

> > I think there's a one-line fix, attached: just add the number of changes
> > in a subxact to nentries_mem when the transaction is assigned to the
> > parent.
> 
> Isn't this going to cause significant breakage, because we rely on
> nentries_mem to be accurate?
> 
>     /* try to load changes from disk */
>     if (entry->txn->nentries != entry->txn->nentries_mem)

Bahh.

Are you suggesting I should try a more thorough rewrite of
reorderbuffer.c?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services