Re: pg_partition_tree crashes for a non-defined relation

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pg_partition_tree crashes for a non-defined relation
Дата
Msg-id 20181209224221.GB3710@paquier.xyz
обсуждение исходный текст
Ответ на Re: pg_partition_tree crashes for a non-defined relation  (Stephen Frost <sfrost@snowman.net>)
Ответы Re: pg_partition_tree crashes for a non-defined relation  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-hackers
On Sun, Dec 09, 2018 at 12:49:18PM -0500, Stephen Frost wrote:
> Looks alright on a quick glance, but shouldn't you also update the
> comment..?

The comment on HEAD or with the patch is that:
    /* Only allow relation types that can appear in partition trees. */

This still looks adapted to me.  Or would you reword it because "allow"
rather implies that an ERROR is returned?  Would you prefer changing it
something like that perhaps:
"Return NULL for relation types that do not appear in partition trees."
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: pg_partition_tree crashes for a non-defined relation
Следующее
От: Tom Lane
Дата:
Сообщение: Re: automatically assigning catalog toast oids