At Tue, 4 Dec 2018 11:37:16 -0500, Stephen Frost <sfrost@snowman.net> wrote in
<20181204163716.GR3415@tamriel.snowman.net>
> Thanks to everyone for sharing their thoughts here, the goal is simply
> to try and have the comments as clear as we can for everyone.
>
> Please find attached a larger rewording of the comment in xlogrecord.h,
> and a minor change to xloginsert.c to clarify that we're removing a hole
> and not doing compression at that point.
>
> Other thoughts on this..?
Thank you for the complete rewriting. It makes the description
clearer at least for me, execpt the following:
> * present is BLCKSZ - the length of "hole" bytes.
Maybe it's because I'm not so accustomed to punctuation marks but
I was confused for a second because the '-' didn't look to me a
minus sign, but a dash. If it is not specific to me, a word
'minus' seems better or, (BLCKSZ - <the length of "hole">) bytes
is clearer .... for me.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center