Re: [Todo item] Add entry creation timestamp column topg_stat_replication

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [Todo item] Add entry creation timestamp column topg_stat_replication
Дата
Msg-id 20181130085415.GI2267@paquier.xyz
обсуждение исходный текст
Ответ на RE: [Todo item] Add entry creation timestamp column topg_stat_replication  ("myungkyu.lim" <myungkyu.lim@samsung.com>)
Ответы Re: [Todo item] Add entry creation timestamp column topg_stat_replication  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Thu, Nov 29, 2018 at 05:43:26PM +0900, myungkyu.lim wrote:
> Changed field name 'last_msg_send_time' to 'reply_time'.

Looks pretty to me at quick glance, unfortunately I have not spent much
time on it, particularly testing it.

+    <row>
+     <entry><structfield>reply_time</structfield></entry>
+     <entry><type>timestamp with time zone</type></entry>
+     <entry>Send time of last message received from WAL
receiver</entry>
+    </row>
This is a bit confusing as this counts for the last *standby* message
('r'), and not the last feedback message ('h').

+   /*
+    * timestamp of the latest message, reported by standby server
+   */
+   TimestampTz replyTime;

A small indentation problem, not a big deal.

Sawada-san, perhaps you would like to look at it?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Adrien NAYRAT
Дата:
Сообщение: Re: New GUC to sample log queries
Следующее
От: Dmitry Dolgov
Дата:
Сообщение: Re: Changing the autovacuum launcher scheduling; oldest table first algorithm