Re: worker_spi shouldn't execute again on sigterm

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: worker_spi shouldn't execute again on sigterm
Дата
Msg-id 20181129011120.GD626@paquier.xyz
обсуждение исходный текст
Ответ на worker_spi shouldn't execute again on sigterm  (Jeremy Finzel <finzelj@gmail.com>)
Ответы Re: worker_spi shouldn't execute again on sigterm  (Thomas Munro <thomas.munro@enterprisedb.com>)
Список pgsql-hackers
On Wed, Nov 28, 2018 at 09:55:37AM -0600, Jeremy Finzel wrote:
> I noticed that the way the test module worker_spi is written, it will
> execute the main loop SQL one more time after it gets a sigterm, THEN exit
> 1.  This was surprising to me where I used this module as a pattern for my
> own background worker as I would have thought it should bail immediately
> without executing any more SQL.
>
> Shouldn't we add something like this line before it enters the phase where
> it starts the transaction and executes the SQL?

Yeah, I agree that this is a bad idea.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Ideriha, Takeshi"
Дата:
Сообщение: minor typo in dsa.c
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: minor typo in dsa.c