On 2018-11-27 00:26:55 -0800, Andres Freund wrote:
> Hi,
>
> On 2018-11-26 22:56:09 -0600, Justin Pryzby wrote:
> > On Mon, Nov 26, 2018 at 07:00:35PM -0800, Andres Freund wrote:
> > > Could you check that the attached patch this also fixes your original
> > > issue? Going through the code to see if there's other occurances of
> > > this.
> >
> > Confirmed that fixes my crash.
>
> Thanks a lot for narrowing down your crash to something I can reproduce!
>
>
> Here's a more complete patch, with a testcase.
>
> Tom, the test creates a 1100k column table (using \set ECHO none +
> gexec), but with a small row. Currently it's not dropped after the
> table, as I thought it might be worthwhile to be tested by
> pg_dump/upgrade etc too. You're probably the person most concerned with
> test runtimes, ... Any concerns about that? The table creation is
> quick*, on the order of 30ms.
And pushed. Justin, thanks again for reporting the bug and then
narrowing it down to a reproducible test case! Would've been much harder
to diagnose without that.
I'll look into your comments patch in a bit.
Greetings,
Andres Freund