Re: pg_dumpall --exclude-database option

On Wed, Oct 31, 2018 at 05:44:26PM +0100, Fabien COELHO wrote:
> Patch v4 applies cleanly, compiles, doc generation ok, global & local tests
> ok.

+# also fails for -r and -t, but it seems pointless to add more tests
for those.
+command_fails_like(
+       [ 'pg_dumpall', '--exclude-database=foo', '--globals-only' ],
+       qr/\Qpg_dumpall: option --exclude-database cannot be used
together with -g\/--globals-only\E/,
+       'pg_dumpall: option --exclude-database cannot be used together
with -g/--globals-only');

Usually testing all combinations is preferred, as well as having one
error message for each pattern, which is also more consistent with all
the other sanity checks in pg_dumpall.c and such.
--
Michael