Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru
Дата
Msg-id 20181002001151.GP11712@paquier.xyz
обсуждение исходный текст
Ответ на Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru  (Masahiko Sawada <sawada.mshk@gmail.com>)
Ответы Re: pgsql: Improve autovacuum logging for aggressive andanti-wraparound ru
Список pgsql-hackers
On Fri, Sep 28, 2018 at 01:53:14PM +0900, Masahiko Sawada wrote:
> I agree. Can we fix this simply by the attached patch?

Thanks for sending a patch.

+    /* autovacuum cannot be anti-wraparound and not aggressive vacuum */
+    Assert(aggressive);
+    msgfmt = _("automatic aggressive vacuum to prevent wraparound of table \"%s.%s.%s\": index scans: %d\n");

While adding this comment in lazy_vacuum_rel() is adapted, I think that
we ought to make the assertion check more aggressive by not having it
depend on if log_min_duration is set or not.  So why not moving that to
a place a bit higher, where aggressive gets defined?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Add SKIP LOCKED to VACUUM and ANALYZE
Следующее
От: Tom Lane
Дата:
Сообщение: Re: snprintf.c hammering memset()