Re: dbsize patch

Andreas Pflug <pgadmin@pse-consulting.de> writes:
> Hm, these are all implementable as SQL functions, do we need these hard
> coded too?

> e.g.
> create function aggregate_relation_size(oid) returns int8 as $CODE$
> select sum(pg_relation_size(indexrelid)) from pg_index where indrelid=$1;
> $CODE$ language 'SQL'

Your suggestion would be more compelling if the example were correct ;-).
Consider more than one index on the same table.

This does raise the question of whether the C implementations count the
right things either --- I have not looked.  Neil, I trust you're going
to review this and not just apply it?

            regards, tom lane