Re: pgsql: Allow extensions to install built as well as unbuiltheaders.

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pgsql: Allow extensions to install built as well as unbuiltheaders.
Дата
Msg-id 20180906051608.GI2726@paquier.xyz
обсуждение исходный текст
Ответ на pgsql: Allow extensions to install built as well as unbuilt headers.  (Andrew Gierth <rhodiumtoad@postgresql.org>)
Ответы Re: pgsql: Allow extensions to install built as well as unbuilt headers.  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Re: pgsql: Allow extensions to install built as well as unbuilt headers.  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Список pgsql-committers
Hi Andrew,

On Wed, Sep 05, 2018 at 09:45:49PM +0000, Andrew Gierth wrote:
> Allow extensions to install built as well as unbuilt headers.
>
> Commit df163230b overlooked the case that an out-of-tree extension
> might need to build its header files (e.g. via ./configure). If it is
> also doing a VPATH build, the HEADERS_* rules in the original commit
> would then fail to find the files, since they would be looking only
> under $(srcdir) and not in the build directory.
>
> Fix by adding HEADERS_built and HEADERS_built_$(MODULE) which behave
> like DATA_built in that they look in the build dir rather than the
> source dir (and also make the files dependencies of the "all" target).
>
> No Windows support appears to be needed for this, since it is only
> relevant to out-of-tree builds (no support exists in Mkvcbuild.pm to
> build extension header files in any case).

prairiedog is unhappy with this commit:
make -C ../../../contrib/spi
../../src/makefiles/pgxs.mk:140: Extraneous text after `else' directive
../../src/makefiles/pgxs.mk:144: *** only one `else' per conditional.
Stop.
make[2]: *** [submake-contrib-spi] Error 2
make[2]: *** Waiting for unfinished jobs....
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2018-09-05%2023%3A21%3A01
--
Michael

Вложения

В списке pgsql-committers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: pgsql: Fix the overrun in hash index metapage for smaller block sizes.
Следующее
От: Andrew Gierth
Дата:
Сообщение: Re: pgsql: Allow extensions to install built as well as unbuilt headers.