On Sat, Sep 01, 2018 at 03:32:10PM -0400, Tom Lane wrote:
> Fair enough. I renamed the types as suggested, changed a few more
> places for consistency's sake, and pushed.
Thanks!
> There still remain some places where palloc(BLCKSZ) or equivalent is used,
> but there's no matching pfree. In a lot of them the buffer is returned
> to the caller so there's no choice. It's likely that some are just
> leaking the storage transiently and we could convert them to using a
> PGAlignedBlock local variable, but I didn't bother trying to do the
> analysis.
At quick glance, I am not seeing anything critical. So the result looks
good to me.
--
Michael