Re: Documentaion fix.

At Fri, 3 Aug 2018 04:13:56 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20180802191356.GB2247@paquier.xyz>
> On Wed, Aug 01, 2018 at 01:04:37PM +0900, Kyotaro HORIGUCHI wrote:
> > The query and the result with four columns fit the current width.
> 
> Just wondering, what is your reason behind the addition of restart_lsn?
> This part of the documentation focuses on slot creation, so slot_name,
> slot_type and active would be representative enough, no?

The first reason was the example looks having a bit too many
space around only with three other columns.

A more serious reason is that I wanted to show a slot with what
properties is created in the example and I thought that
restart_lsn and temporary are significant. Howerver restart_lsn
is always a part of the pg_replication_slots, we don't have
"temprary" before 10. Addition to that, adding it makes the
SELECT line stick out of the width.

That said, I don't object to reduce the columns. Please find the
attached.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
From 7e750c902f594b0a00c1f579518a74947a755d05 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Wed, 1 Aug 2018 11:50:03 +0900
Subject: [PATCH] Documentation fix of "Log-Shipping Standy Servers" for
 master.

The example output of pg_replication_slot is wrong. Correct and make
the output stable by explicitly specifying a part of the all columns
in pg_replication_slots.
---
 doc/src/sgml/high-availability.sgml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index 934eb9052d..3c5f3fc6a9 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -966,10 +966,12 @@ postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot');
 -------------+-----
  node_a_slot |
 
-postgres=# SELECT * FROM pg_replication_slots;
-  slot_name  | slot_type | datoid | database | active | xmin | restart_lsn | confirmed_flush_lsn
--------------+-----------+--------+----------+--------+------+-------------+---------------------
- node_a_slot | physical  |        |          | f      |      |             |
+postgres=# SELECT slot_name, slot_type, active FROM pg_replication_slots;
+  slot_name  | slot_type | active 
+-------------+-----------+--------
+ node_a_slot | physical  | f
+(1 row)
+
 (1 row)
 </programlisting>
      To configure the standby to use this slot, <varname>primary_slot_name</varname>
-- 
2.16.3

From 0192ad0d7c674eff11285f68ea2128ad50ecef10 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Wed, 1 Aug 2018 12:41:03 +0900
Subject: [PATCH] Documentation fix of "Log-Shipping Standy Servers" for PG95.

The example output of pg_replication_slot is wrong. Correct and make
the output stable by explicitly specifying a part of the all columns
in pg_replication_slots.
---
 doc/src/sgml/high-availability.sgml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index 35daf0103a..3f33c39bd2 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -931,10 +931,10 @@ postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot');
 -------------+---------------
  node_a_slot |
 
-postgres=# SELECT * FROM pg_replication_slots;
-  slot_name  | slot_type | datoid | database | active | xmin | restart_lsn
--------------+-----------+--------+----------+--------+------+-------------
- node_a_slot | physical  |        |          | f      |      |
+postgres=# SELECT slot_name, slot_type, active FROM pg_replication_slots;
+  slot_name  | slot_type | active 
+-------------+-----------+--------
+ node_a_slot | physical  | f
 (1 row)
 </programlisting>
      To configure the standby to use this slot, <varname>primary_slot_name</>
-- 
2.16.3