On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote:
> >> The pg_upgrade makefile does in fact use $(SHELL), so it will default to
> >> whatever shell configure used.
>
> > It will not, because we don't set $(SHELL) anywhere. $(SHELL) is not @SHELL@.
> > In our makefiles, $(SHELL) is always /bin/sh, the GNU make default.
>
> Oh! Hm, I wonder whether we shouldn't do that, ie add SHELL = @SHELL@
> to Makefile.global.in.
I see that as the right way forward.