On 2018-Jun-29, Amit Langote wrote:
> On 2018/06/29 6:23, Peter Eisentraut wrote:
> > On 6/28/18 22:52, Alvaro Herrera wrote:
> >>> Couldn't psql chase the pg_depend links to find inherited triggers?
> >>
> >> Yeah, I thought this would be exceedingly ugly, but apparently it's not
> >> *that* bad -- see the attached patch, which relies on the fact that
> >> triggers don't otherwise depend on other triggers. We don't use this
> >> technique elsewhere in psql though.
> >
> > Yeah, relying on pg_depend to detect relationships between catalog
> > objects is a bit evil. We do use this for detecting sequences linked to
> > tables, which also has its share of problems. Ideally, there would be a
> > column in pg_trigger, perhaps, that makes this link explicit. But we
> > are looking here for a solution without catalog changes, I believe.
>
> +1 if that gets the job done.
Okay, pushed that way.
We can redo this if/when we add support for cloning BEFORE row triggers,
which are going to need the trigger link info, I suspect.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services