Re: Minor comment update in execPartition.c

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Minor comment update in execPartition.c
Дата
Msg-id 20180425020509.ypsb2gs3pzaftbgy@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Minor comment update in execPartition.c  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Ответы Re: Minor comment update in execPartition.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Список pgsql-hackers
Amit Langote wrote:

> > I think we should remove the words "if not already done" from that
> > comment because 1) that function is called if the partition wasn't
> > already initialized and 2) that function assumes that.  Attached is a
> > small patch for removing the words.
> 
> Thanks, sounds fine.  I think those words remain from earlier versions of
> the patch committed as edd44738bc8 [1], where there used to be a fast-path
> return if the ResultRelInfo was already non-NULL for the passed in index.

Makes sense -- pushed, thanks both.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: Oddity in tuple routing for foreign partitions
Следующее
От: Michael Paquier
Дата:
Сообщение: Typo in JIT documentation