Re: Commit 4dba331cb3 broke ATTACH PARTITION behaviour.

>      /*
> -     * Check whether default partition has a row that would fit the partition
> -     * being attached.
> +     * Check if the default partition contains a row that would belong in the
> +     * partition being attached.
>       */
> -    defaultPartOid =
> -        get_default_oid_from_partdesc(RelationGetPartitionDesc(rel));
>      if (OidIsValid(defaultPartOid))

Oh my.  This code is terrible, and I think this patch is wrong.  More
later.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services