Pushed now, to branches master and pg10, with Tomas changes. I made a
few changes of my own
1. you forgot to update various src/backend/nodes/ files
2. I got rid of "NameData stxname" variable in CreateStatistics, which
seems pointless now. We can work with a cstring only. Not sure why we
had that one ...
3. I chose not to backpatch the node->stxcomment thing. It makes me
nervous to modify a parse node. So cloning the comments is a PG11
thing. Hopefully it's not *too* bad ...
4. See elsewhere in the thread about list_copy vs. list_concat :-)
Thanks,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services