Re: Incorrect use of "an" and "a" in code comments and docs

Поиск
Список
Период
Сортировка
От Abhijit Menon-Sen
Тема Re: Incorrect use of "an" and "a" in code comments and docs
Дата
Msg-id 20180305055118.vkqfmfrrer7ukpsw@toroid.org
обсуждение исходный текст
Ответ на Re: Incorrect use of "an" and "a" in code comments and docs  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Incorrect use of "an" and "a" in code comments and docs  (Michael Paquier <michael@paquier.xyz>)
Re: Incorrect use of "an" and "a" in code comments and docs  (Andres Freund <andres@anarazel.de>)
Re: Incorrect use of "an" and "a" in code comments and docs  (Thomas Munro <thomas.munro@enterprisedb.com>)
Список pgsql-hackers
At 2018-03-05 14:42:14 +0900, michael@paquier.xyz wrote:
>
> > - sinval is a signal invalidation, so it seems to me that "a" is
> > correct, not "an".

I guess it depends on whether you read it as "sin-val" or "ess-inval".

> diff --git a/src/backend/access/gin/ginvacuum.c b/src/backend/access/gin/ginvacuum.c
> index 398532d80b..8b08b46ff6 100644
> --- a/src/backend/access/gin/ginvacuum.c
> +++ b/src/backend/access/gin/ginvacuum.c
> @@ -381,7 +381,7 @@ ginVacuumPostingTreeLeaves(GinVacuumState *gvs, BlockNumber blkno, bool isRoot)
>  
>          /*
>           * All subtree is empty - just return true to indicate that parent
> -         * must do a cleanup. Unless we are ROOT an there is way to go upper.
> +         * must do a cleanup. Unless we are ROOT and there is way to go upper.
>           */

That particular comment could use some more changes. :-)

-- Abhijit


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Incorrect use of "an" and "a" in code comments and docs
Следующее
От: Tom Lane
Дата:
Сообщение: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly