On Wed, Feb 28, 2018 at 06:37:27PM -0500, Tom Lane wrote:
> And on top of that, there's src/common/base64.c with again almost the
> same functionality. But refactoring to fix that would be a bit invasive
> and not something to back-patch. I think what you did here is appropriate
> as a minimal portability fix. Maybe later somebody will look into
> removing the duplication, as a HEAD-only improvement.
Thanks for pushing the patch.
base64.c ignores some whitespace handling, which is in line with what
the RFCs of SCRAM expect when doing conversion of the data exchanged in
the protocol so that's a bit more different than the other
implementations. Maybe that's worth refactoring, still I am not
completely convinced that we have much to gain from such a move either.
--
Michael