Re: Sigh, I broke crake again

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: Sigh, I broke crake again
Дата
Msg-id 20180227184219.xbzdier34oqybuih@alap3.anarazel.de
обсуждение исходный текст
Ответ на Sigh, I broke crake again  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Sigh, I broke crake again
Список pgsql-hackers
Hi,

On 2018-02-27 13:36:59 -0500, Tom Lane wrote:
> I just committed some regression test cleanup that removed or renamed
> a couple of C-language functions in regress.so.  I see that crake is
> now failing XversionUpgrade tests, and although I can't see the details,
> I bet the problem is from trying to load CREATE FUNCTION commands from
> the old regression databases that now don't point to an existing C
> function.
> 
> Does it seem practical to adjust TestUpgradeXversion.pm to cope with
> this change?  An alternative answer is to put back C-language stubs
> in regress.c for the removed functions, but that seems a bit grotty.

Could we just drop the relevant functions in the course of the test?

Greetings,

Andres Freund


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [HACKERS] Partition-wise aggregation/grouping
Следующее
От: Tom Lane
Дата:
Сообщение: Re: atomics.h may not be included from frontend code