On Tue, Feb 27, 2018 at 11:43:34AM +0100, Magnus Hagander wrote:
> On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner <vitus@wagner.pp.ru> wrote:
> > These errors seems to be caused by commit 91f3ffc5249
> > which improves readability of src/bin/scripts/Makefile for
> > humans by moving list of common object files into variable.
> >
> > Unfortunately, it makes this Makefile unreadable for perl scripts
> > in src/tools/msvc, which generate Microsift Visual Studio projects.
> It's also interesting to note that this did not break in HEAD, 10 or 9.6.
> And none of those actually have the SCRIPTS_COMMON code.
>
> I'm unsure why this was introduced in 9.5 and earlier, but not in the newer
> ones. This smells like a possible backpatch mistake, in which case that
> part should probably be backed out of the old branches rather than teaching
> mkvcbuild about it.
>
> Noah? Can you confirm if it was intentional?
It was intentional; the release made common.c depend on dumputils.c in 9.5 and
earlier, so everything that needs common.c now needs all four files. (From 9.6,
relevant code had moved to libpgfeutils.) Nonetheless, your fix was correct.
Thanks for pushing it.