Re: Removing WITH clause support in CREATE FUNCTION, for isCachableand isStrict

On Thu, Jan 25, 2018 at 06:30:04PM -0500, Tom Lane wrote:
> I poked into the git log and confirmed Michael's statement that
> CREATE FUNCTION ... WITH has been documented as deprecated since
> 7.3 (commit 94bdc4855 to be exact).

Thanks for the confirmation.

> I think the original intention was that we'd keep it for PG-specific
> function attributes (ie those not found in the SQL spec), so as to
> avoid creating keywords for every attribute we thought of.  That
> intention has been roundly ignored since then, though, since COST
> and ROWS and LEAKPROOF and PARALLEL (UN)SAFE have all been implemented
> as separate keywords not WITH options.  I'm dubious that that was a good
> plan, but it's probably too late to change direction now.

:(

> In short, I'm on board with removing the WITH clause.  I've not
> reviewed the patch in detail, but will do so and push it if there's
> not objections pretty soon.

Glad to hear that, thanks!
--
Michael