David Steele wrote:
> On 1/8/18 8:58 PM, Peter Eisentraut wrote:
> > Yeah, I didn't like this aspect when this patch was originally
> > submitted. We want to keep the code legible for future new
> > contributors. Having these generic-sounding but specific-in-purpose
> > wrapper functions can be pretty confusing. Let's use mkdir() when it's
> > the appropriate function, and let's figure out a different name for
> > "make a data directory subdirectory in a secure and robust way".
> How about MakeDirectoryDefaultPerm()? That's what I'll go with if I
> don't hear any other ideas. The single call to MakeDirectoryPerm() will
> be reverted to mkdir() and I'll remove the function.
I'd go with MakeDirectory, documenting exactly what it does and why, and
be done with it. If your new function satisfies future users, great; if
not, it can be patched (or not) once we know exactly what these callers
need.
You know, YAGNI.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services