Re: [Patch v2] Make block and file size for WAL and relationsdefined at cluster creation

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [Patch v2] Make block and file size for WAL and relationsdefined at cluster creation
Дата
Msg-id 20180103221100.riszh4c3m2omor5r@alvherre.pgsql
обсуждение исходный текст
Ответ на [Patch v2] Make block and file size for WAL and relations defined atcluster creation  (Remi Colinet <remi.colinet@gmail.com>)
Ответы Re: [Patch v2] Make block and file size for WAL and relations definedat cluster creation
Список pgsql-hackers
Дерево обсуждения 
Remi Colinet wrote:
> Hello,
> 
> This is version 2 of the patch to make the file and block sizes for WAL and
> relations, run-time configurable at initdb.

I don't think this works, since we have a rule that pallocs are
prohibited within critical section and I see that your patch changes
some stack-allocated variables to palloc'ed.  For example I think the
heap_page_prune changes should break some test or other.

This patch is too massive to review.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Дата:
Сообщение: Re: [PATCH] Comment typo in get_collation_name() comment
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [PATCH] Comment typo in get_collation_name() comment