On 2017-11-29 09:41:15 -0500, Robert Haas wrote:
> On Wed, Nov 29, 2017 at 9:26 AM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
> > I'd still like a review of this patch.
>
> I don't think there's much to review apart from this one issue.
> Neither Tom nor I seem to be convinced about:
>
> +/* not worth providing a workaround */
FWIW, I think that's a perfectly reasonable choice. Adding complications
in making static assertions work for random archaic compilers when
compiling with c++ just doesn't seem worth more than a few mins of
thought.
Greetings,
Andres Freund