Andres Freund wrote:
> Hi,
>
> On 2017-10-03 13:58:37 -0400, Robert Haas wrote:
> > On Tue, Oct 3, 2017 at 12:23 PM, Andres Freund <andres@anarazel.de> wrote:
> > > Makes sense?
> >
> > Yes.
>
> Here's an updated version of this patchset.
Maybe it'd be a good idea to push 0001 with some user of restrict ahead
of the rest, just to see how older msvc reacts.
I wonder if it'd be a good idea to nag external users about pq_sendint
usage (is a #warning possible?). OTOH, do we really need to keep it
around? Maybe we should ditch it, since obviously the compat shim can
be installed locally in each extension that really needs it (thinking
that most external code can simply be adjusted to the new functions).
I'm scared about the not-null-terminated stringinfo stuff. Is it
possible to create bugs by polluting a stringinfo with it, then having
the stringinfo be used by unsuspecting code? Admittedly, you can break
things already with the binary appends, so probably not an issue.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers