Re: [HACKERS] [PATCH] Improve geometric types

Hello, just one point on 0001.

The patch replace pg_hypot with hypot in libc. The man page says
as follows.

man 3 hypot
>       If the result overflows, a range error occurs, and the functions return
>       HUGE_VAL, HUGE_VALF, or HUGE_VALL, respectively.
..
>ERRORS
>       See math_error(7) for information on how to determine whether an  error
>       has occurred when calling these functions.
>
>       The following errors can occur:
>
>       Range error: result overflow
>              errno  is  set  to ERANGE.  An overflow floating-point exception
>              (FE_OVERFLOW) is raised.
>
>       Range error: result underflow
>              An underflow floating-point exception (FE_UNDERFLOW) is raised.
>
>              These functions do not set errno for this case.

So, the code seems to need some amendments following to this
spec.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers