Alvaro Herrera wrote:
> Alvaro Herrera wrote:
>
> > Hmm, yeah, that's not good. However, I didn't like the idea of putting
> > it inside the locked area, as it's too much code. Instead I added just
> > before acquiring the spinlock. We cancel the sleep unconditionally
> > later on if we didn't need to sleep after all.
>
> I just noticed that Jacana failed again in the subscription test, and it
> looks like it's related to this. I'll take a look tomorrow if no one
> beats me to it.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2017-07-26%2014%3A39%3A54
Ahh, I misread the message. This one is actually about the replication
*origin* being still active, not the replication *slot*. I suppose
origins need the same treatment as we just did for slots. Anybody wants
to volunteer a patch?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services