[HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

Поиск
Список
Период
Сортировка
От Yugo Nagata
Тема [HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()
Дата
Msg-id 20170720224425.9e967e54.nagata@sraoss.co.jp
обсуждение исходный текст
Ответы Re: [HACKERS] Incorrect comment of XLByteToSeg() andXLByteToPrevSeg()  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Список pgsql-hackers
Hi,

I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg().
This says "Compute ID and segment from an XLogRecPtr", but these
macros compute only segment numbers. I think "Compute a segment number
from an XLogRecPtr" is correct.

The definition of these macros were modified by the following commit,
but the comment were not.

commit dfda6ebaec6763090fb78b458a979b558c50b39b
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:   Sun Jun 24 18:06:38 2012 +0300

Regards,

-- 
Yugo Nagata <nagata@sraoss.co.jp>

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Yugo Nagata
Дата:
Сообщение: Re: [HACKERS] xlogfilename
Следующее
От: Thom Brown
Дата:
Сообщение: Re: [HACKERS] pg_upgrade failed if view is based on sequence