Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAMmessage.

On Fri, Jun 02, 2017 at 02:20:00AM -0400, Tom Lane wrote:
> BTW, since you mention COMMERROR uses in auth.c, isn't the usage at
> line 687 wrong?  It sure looks like the author supposed that that
> ereport call wouldn't return, but it will.  Adjacent similar calls
> clean up and return NULL.

Probably, though one could argue for proceeding with the short password.
Deserves a comment if log-only is intentional.

The lack of an exit after COMMERROR "client selected an invalid SASL
authentication mechanism" looks like a bug.


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs