On 2017-06-01 19:08:33 +0200, Petr Jelinek wrote:
> On 01/06/17 16:51, Robert Haas wrote:
> > On Wed, May 31, 2017 at 8:07 PM, Andres Freund <andres@anarazel.de> wrote:
> >> Here's a patch doing what I suggested above. The second patch addresses
> >> an independent oversight where the post alter hook was invoked before
> >> doing the catalog update.
> >
> > 0002 is a slam-dunk. I don't object to 0001 but haven't reviewed it carefully.
> >
>
> I did go over the code (ie didn't do actual testing), and I like it much
> better than the current state. Both in terms of making the behavior more
> consistent and the fact that the code is simpler.
>
> So +1 to go ahead with both patches.
Thanks for the look! I unfortunately forgot to credit you as a
reviewer, sorry for that.
Pushed both.
- Andres