Re: [HACKERS] WITH clause in CREATE STATISTICS

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [HACKERS] WITH clause in CREATE STATISTICS
Дата
Msg-id 20170512214426.sdzcocysfv6ykjjr@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: [HACKERS] WITH clause in CREATE STATISTICS  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] WITH clause in CREATE STATISTICS
Список pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Tom Lane wrote:
> >> Oh, sorry --- I already pushed something about this.
> 
> > That's fine, thanks.
> 
> Oh, I see your patch also fixes missing code in getObjectDescription().
> We need that.  Is there a decent way to get the compiler to warn about
> that oversight?

We could remove the default clause.  That results in the expected
warning, and no others (i.e. the switch was already complete):

/pgsql/source/master/src/backend/catalog/objectaddress.c:2657:2: warning: enumeration value 'OCLASS_STATISTIC_EXT' not
handledin switch [-Wswitch]
 

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] WITH clause in CREATE STATISTICS
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] WITH clause in CREATE STATISTICS