Re: Re: Declarative partitioning optimization for largeamount of partitions

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Re: Re: Declarative partitioning optimization for largeamount of partitions
Дата
Msg-id 20170324161204.GD16830@e733.localdomain
обсуждение исходный текст
Ответ на [HACKERS] Declarative partitioning optimization for large amount of partitions  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Список pgsql-hackers
Hi Teodor,

Thanks a lot for a review!

> > step1 In pgstat_report_stat() you remove one by one entries from hash and
> > remove them all. Isn't it better to hash_destroy/hash_create or even let hash
> > lives in separate memory context and just resets it?

Agree, fixed.

> > step1 Again, pgstat_report_stat(), all-zero entries aren't deleted from hash
> > although they will be free from point of view of pgStatTabList.

Good point! Fixed.

--
Best regards,
Aleksander Alekseev

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Khandekar
Дата:
Сообщение: Re: Parallel Append implementation
Следующее
От: Robert Haas
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()