Still about 0003. dependencies.c comment at the top of the file should
contain some details about what is it implementing and a general
description of the algorithm and data structures. As before, it's best
to have the main entry point build_mv_dependencies at the top, the other
public functions, keeping the internal routines at the bottom of the
file. That eases code study for future readers. (Minimizing number of
function prototypes is not a goal.)
What is MVSTAT_DEPS_TYPE_BASIC? Is "functional dependencies" really
BASIC? I wonder if it should be TYPE_FUNCTIONAL_DEPS or something.
As with pg_ndistinct_out, there's no need to pstrdup(str.data), as it's
already palloc'ed in the right context.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services