Re: [HACKERS] Minor correction in alter_table.sgml

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [HACKERS] Minor correction in alter_table.sgml
Дата
Msg-id 20161222141759.z6lkotsyd4d7fdgg@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: [HACKERS] Minor correction in alter_table.sgml  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-hackers
Stephen Frost wrote:
> Tom,
> 
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:

> > BTW, so far as the HEAD version of this patch goes, I notice that
> > ATTACH PARTITION and DETACH PARTITION were recently added to the
> > list of exceptions.  But they're not exceptions according to this
> > wording: they act on more than one table (the parent and the
> > partition), no?  So we could simplify the sentence some more by
> > removing them again.
> 
> I had considered removing those but thought that some users might think
> that they're only "altering" one table and therefore felt it made sense
> to keep those explicitly listed.

I agree with Stephen; it's not crystal clear from the user's POV that
the command is altering two tables.  It's worth mentioning this
explicitly; otherwise this is just a documented gotcha.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: [HACKERS] Minor correction in alter_table.sgml
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Minor correction in alter_table.sgml