Hi Gilles,
On Sun, 27 Nov 2016 21:54:46 +0100
Gilles Darold <gilles.darold@dalibo.com> wrote:
> I've attached the v15 of the patch that applies your changes/fixes ...
Per the following:
On Mon, 21 Nov 2016 13:17:17 -0500
Robert Haas <robertmhaas@gmail.com> wrote:
> It would really be much better to submit anything that's not
> absolutely necessary for the new feature as a separate patch, rather
> than bundling things together.
The following patch should really be submitted (along with
your patch) as a separate and independent patch:
patch_pg_current_logfile-v14.diff.cleanup_rotate
It introduces no new functionality and only cleans up existing code.
The idea is to give the maintainers only one thing to consider
at a time. It can be looked at along with your patch since it
touches the same code but, like the GUC symbol patch, it's
not a necessary part of your patch's functionality.
At present patch_pg_current_logfile-v14.diff.cleanup_rotate is bundled
in with the v15 patch.
Regards,
Karl <kop@meme.com>
Free Software: "You don't pay back, you pay forward." -- Robert A. Heinlein