Re: [PATCH] Generic type subscription
От | Aleksander Alekseev |
---|---|
Тема | Re: [PATCH] Generic type subscription |
Дата | |
Msg-id | 20161115080324.GA5351@e733.localdomain обсуждение исходный текст |
Ответ на | Re: [PATCH] Generic type subscription (Dmitry Dolgov <9erthalion6@gmail.com>) |
Ответы |
Re: [PATCH] Generic type subscription
|
Список | pgsql-hackers |
Hello. I took a look on the latest -v4 patch. I would like to note that this patch breaks a backward compatibility. For instance sr_plan extension[1] stop to compile with errors like: ``` serialize.c:38:2: error: unknown type name ‘ArrayRef’ JsonbValue *ArrayRef_ser(const ArrayRef *node, JsonbParseState *state, bool sub_object); ^ serialize.c:913:2: error: unknown type name ‘ArrayRef’ JsonbValue *ArrayRef_ser(const ArrayRef *node, JsonbParseState *state, bool sub_object) ^ In file included from sr_plan.h:4:0, from serialize.c:1: ... ``` Other extensions could be affected as well. I'm not saying that it's a fatal drawback, but it's definitely something you should be aware of. I personally strongly believe that we shouldn't break extensions between major releases or at least make it trivial to properly rewrite them. Unfortunately it's not a case currently. [1] https://github.com/postgrespro/sr_plan -- Best regards, Aleksander Alekseev
В списке pgsql-hackers по дате отправления: