Re: Radix tree for character conversion

Поиск
Список
Период
Сортировка
От Kyotaro HORIGUCHI
Тема Re: Radix tree for character conversion
Дата
Msg-id 20161108.110258.59832499.horiguchi.kyotaro@lab.ntt.co.jp
обсуждение исходный текст
Ответ на Re: Radix tree for character conversion  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: Radix tree for character conversion
Список pgsql-hackers
Hello,

At Mon, 7 Nov 2016 17:19:29 +0100, Daniel Gustafsson <daniel@yesql.se> wrote in
<39E295B9-7391-40B6-911D-FE852E4604BD@yesql.se>
> > On 07 Nov 2016, at 12:32, Daniel Gustafsson <daniel@yesql.se> wrote:
> > 
> >> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> >> 
> >> I'm not sure how the discussion about this goes, these patches
> >> makes me think about coding style of Perl.
> > 
> > Some of this can absolutely be considered style and more or less down to
> > personal preference.  I haven’t seen any coding conventions for Perl so I
> > assume it’s down to consensus among the committers.
> 
> Actually, scratch that; there is of course a perltidy profile in the pgindent
> directory.  I should avoid sending email before coffee..

Hmm.  Somehow perl-mode on my Emacs is stirring with
ununderstandable indentation and I manually correct them so it is
highly probable that the style of this patch is not compatible
with the defined style. Anyway it is better that pgindent
generates smaller patch so I'll try it.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Hao Lee
Дата:
Сообщение: Do we need use more meaningful variables to replace 0 in catalog head files?
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Do we need use more meaningful variables to replace 0 in catalog head files?