On 2016-09-12 09:14:47 -0700, Andres Freund wrote:
> On 2016-09-12 10:19:14 -0400, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> >
> > > 0001-Add-some-more-targetlist-srf-tests.patch
> > > Add some test.
> >
> > I think you should go ahead and push this tests-adding patch now, as it
> > adds documentation of the current behavior that is a good thing to have
> > independently of what the rest of the patchset does. Also, I'm worried
> > that some of the GROUP BY tests might have machine-dependent results
> > (if they are implemented by hashing) so it would be good to get in a few
> > buildfarm cycles and let that settle out before we start changing the
> > answers.
>
> Generally a sound plan - I started to noticeably expand it though,
> there's some important edge cases it didn't cover.
Attached is a noticeably expanded set of tests, with fixes for the stuff
you'd found. I plan to push that soon-ish. Independent of the approach
we'll be choosing, increased coverage seems quite useful.
Andres