On Mon, Sep 05, 2016 at 02:43:48PM +0900, Michael Paquier wrote:
> On Mon, Sep 5, 2016 at 9:18 AM, Noah Misch <noah@leadboat.com> wrote:
> > Every vcbuild and msbuild invocation ought to recognize this variable, so
> > please update the two places involving ecpg_regression.proj. Apart from that,
> > the patch looks good.
>
> Good catch. I did not notice those during my lookups of those patches.
> Not my intention to bump into Christian's feet, but here are updated
> patches.
Committed.
> Actually, is that worth adding for clean.bat? I doubt that many people
> would care if MSBFLAGS is not supported in it. The cleanup script is
> not the bottleneck, the build script is. I added it in the patch 0001
> attached but I doubt that's worth it to be honest.
If parallelism were the only consideration, then I would agree. We don't
know, in general, how each operation will respond to arbitrary flags the user
selects. I did remove your clean.bat documentation change; documenting
MSBFLAGS in the one place suffices.