Re: Missing checks when malloc returns NULL...
От | Aleksander Alekseev |
---|---|
Тема | Re: Missing checks when malloc returns NULL... |
Дата | |
Msg-id | 20160829141315.GB8340@e733 обсуждение исходный текст |
Ответ на | Re: Missing checks when malloc returns NULL... (Aleksander Alekseev <a.alekseev@postgrespro.ru>) |
Ответы |
Re: Missing checks when malloc returns NULL...
|
Список | pgsql-hackers |
> Hello, Michael > > > I don't know how you did it, but this email has visibly broken the > > original thread. Did you change the topic name? > > I'm very sorry for this. I had no local copy of this thread. So I wrote a > new email with the same subject hoping it will be OK. Apparently right > In-Reply-To header is also required. > > > if (prodesc->user_proname == NULL || prodesc->internal_proname == NULL) > > + { > > + free(prodesc); > > I think that prodesc->user_proname and prodesc->internal_proname should > also be freed if they are not NULL's. > > > By the way maybe someone knows other procedures besides malloc, realloc > > and strdup that require special attention? > > I recalled that there is also calloc(). I've found four places that use > calloc() and look suspicious to me (see attachment). What do you think - > are these bugs or not? I've just realized that there is also malloc-compatible ShmemAlloc(). Apparently it's return value sometimes is not properly checked too. See attachment. -- Best regards, Aleksander Alekseev
Вложения
В списке pgsql-hackers по дате отправления: