Anastasia Lubennikova wrote:
> By the way, I thought about looking at the mentioned patch and
> probably reviewing it, but didn't find any of your patches on the
> current commitfest. Could you point out the thread?
Sorry, I haven't posted anything yet.
> >Agreed. But changing its name while keeping it in heapam.c does not
> >really improve things enough. I'd rather have it moved elsewhere that's
> >not specific to "heaps" (somewhere in access/common perhaps). However,
> >renaming the functions would break third-party code for no good reason.
> >I propose that we only rename things if we also break it for other
> >reasons (say because the API changes in a fundamental way).
>
> Yes, I agree that it should be moved to another file.
> Just to be more accurate: it's not in heapam.c now, it is in
> "src/backend/catalog/heap.c" which requires much more changes
> than I did.
Argh. Clearly, the code organization in this area is not good at all.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services