Re: OpenSSL 1.1 breaks configure and more

Re: Andreas Karlsson 2016-07-01 <688a438c-ccc2-0431-7100-26e418fc3bca@proxel.se>
> Hi,
> 
> Here is an initial set of patches related to OpenSSL 1.1. Everything should
> still build fine on older OpenSSL versions (and did when I tested with
> 1.0.2h).

Hi Andreas,

thanks for the patches. I applied all there patches on top of HEAD
(10c0558f). The server builds and passes "make check", pgcrypto still
needs work, though:

./configure --with-openssl
make world

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute
-Wformat-security-fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I. -I../../src/include
-D_GNU_SOURCE  -c -o openssl.o openssl.c
 
openssl.c:205:13: error: field ‘ctx’ has incomplete type EVP_MD_CTX ctx;            ^
openssl.c: In function ‘digest_free’:
openssl.c:253:2: warning: implicit declaration of function ‘EVP_MD_CTX_cleanup’ [-Wimplicit-function-declaration]
EVP_MD_CTX_cleanup(&digest->ctx);^
 
openssl.c: In function ‘init_openssl_rand’:
openssl.c:990:24: warning: implicit declaration of function ‘RAND_SSLeay’ [-Wimplicit-function-declaration]
RAND_set_rand_method(RAND_SSLeay());                      ^
 
openssl.c:990:24: warning: passing argument 1 of ‘RAND_set_rand_method’ makes pointer from integer without a cast
[-Wint-conversion]
In file included from openssl.c:40:0:
/usr/include/openssl/rand.h:41:5: note: expected ‘const RAND_METHOD * {aka const struct rand_meth_st *}’ but argument
isof type ‘int’int RAND_set_rand_method(const RAND_METHOD *meth);    ^
 
openssl.c: In function ‘px_get_pseudo_random_bytes’:
openssl.c:1017:2: warning: ‘RAND_pseudo_bytes’ is deprecated [-Wdeprecated-declarations] res = RAND_pseudo_bytes(dst,
count);^
 
In file included from openssl.c:40:0:
/usr/include/openssl/rand.h:51:5: note: declared hereDEPRECATEDIN_1_1_0(int RAND_pseudo_bytes(unsigned char *buf, int
num))   ^
 
openssl.c: In function ‘digest_block_size’:
openssl.c:222:1: warning: control reaches end of non-void function [-Wreturn-type]}^
openssl.c: In function ‘digest_result_size’:
openssl.c:214:1: warning: control reaches end of non-void function [-Wreturn-type]}^
<eingebaut>: die Regel für Ziel „openssl.o“ scheiterte
make[2]: *** [openssl.o] Fehler 1
make[2]: Verzeichnis „/home/cbe/projects/postgresql/pg/master/contrib/pgcrypto“ wird verlassen

ii  libssl-dev:amd64        1.1.0~pre5-4     amd64            Secure Sockets Layer toolkit - development files
ii  libssl1.0.0:amd64       1.0.2d-1         amd64            Secure Sockets Layer toolkit - shared libraries
ii  libssl1.0.2:amd64       1.0.2h-1         amd64            Secure Sockets Layer toolkit - shared libraries
ii  libssl1.1:amd64         1.1.0~pre5-4     amd64            Secure Sockets Layer toolkit - shared libraries
ii  openssl                 1.0.2h-1         amd64            Secure Sockets Layer toolkit - cryptographic utility

Christoph