Re: Parallel pg_dump's error reporting doesn't work worth squat
| От | Alvaro Herrera |
|---|---|
| Тема | Re: Parallel pg_dump's error reporting doesn't work worth squat |
| Дата | |
| Msg-id | 20160602161711.GA239156@alvherre.pgsql обсуждение |
| Ответ на | Re: Parallel pg_dump's error reporting doesn't work worth squat (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: Parallel pg_dump's error reporting doesn't work
worth squat
|
| Список | pgsql-hackers |
Tom Lane wrote: > Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes: > > Apart from the invalid snapshot problem, I looked the patch > > previously mentioned mainly for Windows. > > Thanks for looking! > > > Even though the threads started by beginthread cannot be > > terminated cleanly from outside, but the whole process will soon > > terminate anyway, so we could use TreminateThread. This seems > > working. (Attached patch) > > Seems reasonable to me; I was unhappy about the lack of any direct > equivalent to the child SIGTERMs that the Unix code does. Given this testing, it's clear that the timeout on select() is useless; we could get rid of it in vacuumdb.c too. I'll post a patch later. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: