Robert Haas wrote:
> My suggestion is that we switch from using a List to marshal the data
> to using an ExtensibleNode. An advantage of that is that we'd have
> some in-core test coverage for the ExtensibleNode stuff. In theory it
> ought to be simpler and less messy, too, but I guess we'll find out.
So the data in the list has a certain specific meaning according to its
position within the list? And the enum being modified by this patch,
corresponds to knowledge of what each element in the list is? This
seems a bit odd. I agree that something more similar to a struct would
be more appropriate. Maybe there are other ways, but ExtensibleNode
seems like a reasonable tool to use here.
+1 to having in-core use case for ExtensibleNode too.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services