Re: pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner.

Hi,

On 2016-04-17 12:01:48 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Allow Pin/UnpinBuffer to operate in a lockfree manner.
>
> Now that I've had some occasion to look around in bufmgr.c, I am very
> unhappy that there are still boatloads of comments talking about a buffer
> header's spinlock, when there is in fact no spinlock anymore.

That's actually intentional. Alexander had changed those, and it made
the patch a good bit harder to read because there's so many references.
As the new thing is still a spinlock, just not a s_lock.[ch] style on, I
don't see changing all that to be a significant benefit.

- Andres