On 2016-04-13 23:31:21 -0700, Andres Freund wrote:
> I'm also putting up an animal with clang that uses
> CFLAGS='-std=c89 -Wc99-extensions -Werror=c99-extensions'
> which actually catches this.
Hm. Doing so I found the following in 9.3:
/home/andres/src/postgresql-9.3/src/bin/pg_dump/parallel.c:561:23: error: initializer for aggregate is not a
compile-timeconstant [-Werror,-Wc99-extensions] int pipefd[2] =
{pipeMW[PIPE_READ],pipeWM[PIPE_WRITE]}; ^~~~~~~~~~~~~~~~~
which is, afaics, the same class of issue we're hitting on master right
now. I apparently fixed that, via Robert, back in 59202fae0. I'd planned
to put up that animal (mylodon) for all branches, but given that that's
been unfixed for years I'm not sure. What do you think?
- Andres